-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run all compressed tiffs through libtiff #2899
Conversation
release notes #2832 |
Ok, I think this is good. I've removed the tiff_lzw decoder, as it's only used for Tiffs. The packbits decoder is still used in the PsdImagePlugin, so it remains in the tree. Jpeg is obviously used elsewhere, but support in TiffImagePlugin has been removed, as it's got colorspace issues. |
PIL/TiffImagePlugin.py
Outdated
rawmode = 'I;16N' | ||
if '16B' in rawmode: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
;16B
and ;16L
here and below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that's actually necessary, as there's no other use of 16B
without the ;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no use other 16B
, but this more explicitly tells where you are expecting to find this and which part of mode this should be.
files. | ||
.. note:: | ||
|
||
Beginning in version 4.4.0, Pillow requires libtiff to read or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version 5.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're going to have to do a blanket 4.4/5.0 replace.
Supercedes #2882
Fixes #2839, #2503, #1270
Changes proposed in this pull request: